moodle-an-hochschulen / moodle-theme_boost_campus

Moodle 3.x Boost child theme which is intended to meet the needs of university campuses and adds several features and improvements ––– for Moodle 4.x please use our Theme Boost Union
GNU General Public License v3.0
38 stars 25 forks source link

cloze line break fix #5

Closed sennewood closed 7 years ago

sennewood commented 7 years ago

We experienced the following problem with a cloze (DE: Lückentext): at a small screen size the line break got triggered a lot: mdl_gaptext_pre

I fixed this with:

p .subquestion {
   display: inline-block;
}

Now it looks like this: mdl_gaptext_post

abias commented 7 years ago

Hi Sebastian,

thanks for this issue.

At the very beginning of working on theme_boost_campus, we decided (internally) that we would not want to fix bugs of theme_boost in theme_boost_campus if there is a chance to have them solved in theme_boost directly. Otherwise, we would end up with a load of local fixes and overrides which wouldn't be manageable in the long run on the one hand and on the other hand the problem would only be solved for our child theme and not all Boost installations.

That's why I would want to ask you to check this:

Thanks, Alex

sennewood commented 7 years ago

It's from 3.3 and boost. Other test environments I don't have.

When it's not a theme issue, just close it :)

abias commented 7 years ago

Well, if this problem also does appear on theme_boost in Moodle core, I highly encourage you to report it on tracker.moodle.org to have it fixed globally. theme_boost_campus will then most probably inherit this fix from theme_boost.