moodle-an-hochschulen / moodle-theme_boost_campus

Moodle 3.x Boost child theme which is intended to meet the needs of university campuses and adds several features and improvements ––– for Moodle 4.x please use our Theme Boost Union
GNU General Public License v3.0
38 stars 25 forks source link

Footer <520px #93

Closed dennis2menace closed 3 years ago

dennis2menace commented 4 years ago

If you don´t use a layout with different blocks, the Footer is not completely visible due to the CSS: .row-fluid { margin-right: -15px; margin-left: -15px; } I changed it in the advanced settings (raw scss) to .row-fluid { margin-right: 15px; margin-left: 15px; } CIAO Dennis

Kathrin84 commented 4 years ago

Hello @dennis2menace ,

thank you for raising this issue.

I'm not sure if I understand your issue fully. Could you provide more explanation and / or a screenshot and could you please verify if the issue occurs only on Boost Campus or also on theme Boost? Which versions of Moodle and Boost Campus do you use?

Your proposed solution seems a little bit critical to me as you change a general CSS class that is applied in many places throughout Moodle.

Best, Kathrin

dennis2menace commented 4 years ago

The issue only appears on boost_campus. I use the latest version of boost_campus from this git (yesterday about midnight) and Boost delivered with Moodle 3.9.1. The footer is cutted off on the left site:

Bildschirmfoto 2020-09-09 um 08 22 08

on the right site, there´s too much space, so you can swipe the mobile site to the right by accident:

Bildschirmfoto 2020-09-09 um 08 23 21

It is only appearing on mobile devices <520px. On iPad it is fine:

Bildschirmfoto 2020-09-09 um 08 24 06
Kathrin84 commented 4 years ago

Hi @dennis2menace ,

thanks for your further explanation and providing screenshots. Unfortunately I've got no physical device to test your scenario with. So I can only try to simulate this with the browser tools.

However, the simulation in the browser displays everything well with small resolution an not footer blocks enabled: simulated_small_res

Having a look at your navigation bar, I'm wondering that your burger menu item is not on the left side. So I assume you use a child theme of Boost Campus or added rules to the RAW SCSS section?

Can you reproduce the problem on a core Moodle 3.9 with a freshly installed Boost Campus, too?

Best, Kathrin

abias commented 3 years ago

Hi @dennis2menace ,

we surely would have liked to solve this problem.

However, as there wasn't any feedback anymore from you to @Kathrin84 's questions, I will close this now. Please don't hesitate to come back again if you have more information for us.

Cheers, Alex