moodle-an-hochschulen / moodle-theme_boost_campus

Moodle 3.x Boost child theme which is intended to meet the needs of university campuses and adds several features and improvements ––– for Moodle 4.x please use our Theme Boost Union
GNU General Public License v3.0
38 stars 25 forks source link

Moodle 3.10 compatibility #99

Closed yanus closed 3 years ago

yanus commented 3 years ago

I've upgraded to Moodle 3.10 today and the theme CSS seems to be broken, e.g.:

Tested on a clean installation of Moodle 3.10 with Boost Campus v3.9-r1 (see screenshot) Screenshot_2020-11-09 New Site

aguatacuperche commented 3 years ago

Hi,

The code "Raw initial SCSS" does not work either. "Login page background images" also fails.

v3.9-r2

kobajashi77 commented 3 years ago

Same here in 3.10+ (2020110900) . I really appreciate all the work you but in the theme, the navigation extension and all the other plugins. Thank you very much for that! Cheers

abias commented 3 years ago

Hey @yanus @aguatacuperche @kobajashi77,

thank you all for raising these issues with 3.10. You might want to look at the branch https://github.com/moodleuulm/moodle-theme_boost_campus/tree/LMS-5287 where I have push a WIP version of theme_boost_campus which contains fixes for all of these issues but which is not yet officially released for 3.10.

Cheers, Alex

aguatacuperche commented 3 years ago

Hi @abias

I have installed it and it has been resolved by clearing the cache. I have another experimental installation in a 4.0dev test version where it has been fixed as well.

Cheers

yanus commented 3 years ago

Dear @abias,

I can confirm that the new version seems to have solved all issues. Thank you for the great work on the theme!

Cheers, Yannick

kobajashi77 commented 3 years ago

Thanks @abias for your great work. Cheers Tobias

abias commented 3 years ago

The branch for the 3.10 version has now been merged into the master branch. An official release on moodle.org/plugin will follow soon.

Have fun!

Cheers, Alex