Open Menrath opened 1 year ago
Hi @Menrath,
many thanks for creating this issue.
I understand that you have implemented something which allows the admin to pick a navbar background color and adapts the navbar font color automatically, is that right?
Please have a look at #224 where I have just submitted a PR which allows the admin to at least select the brand color as navbar background color.
I could well imagine to see this functionality extended by a "Custom" admin setting value which will reveal a color picker for the navbar background color and navbar font color. While it may be technically interesting, I do not see a real need to let Moodle select the font color automatically.
If you would like to further work towards custom navbar colors, I would appreciate of you could build on the functionality of #224 as soon as this PR is landed.
Extends #39
I started work on this but stumbled into some problems, some can be resolved others have some further impact.
Resolved: Automatically choose the right font-color depending on the contrast, etc.
Needs discussion: The navbar background color might interfere with the
brandcolor
therefore the navigation highlighting of the currently active tab and the edit button might not be visible good enough. I am not sure anymore how much this setting can be generalized in a meaningful way.