search

moodle-an-hochschulen / moodle-theme_boost_union

Theme Boost Union is an enhanced child theme of Boost which is intended, on the one hand, to make Boost simply more configurable and, on the other hand, to provide helpful additional features for the daily Moodle operation of admins, teachers and students.
GNU General Public License v3.0
61 stars 56 forks source link

Bugfix: Fix mustache shortcomings from Boost Core #152

Open abias opened 1 year ago

abias commented 1 year ago

There are some shortcomings in the mustache templates which have been adopted from Boost core to Boost Union.

On the one hand, we should stick as closely to Boost core as possible. On the other hand, these shortcomings require to mute the moodle-plugin-ci mustache checker (see https://github.com/moodle-an-hochschulen/moodle-theme_boost_union/blob/master/.github/workflows/moodle-plugin-ci.yml#L95) to avoid that this check fails again and again.

To allow the mustache tests to run properly, it would be worthwhile to fix the mustache shortcomings from Boost Core in Boost Union finally.

abias commented 1 year ago

The only remaining mustache shortcoming in Boost Union is this one:

(#1) HTML Validation info, line 2: Consider adding a “lang” attribute to the “html” start tag to declare the language of this document. (TYPE html><html ><head)

This issue is highlighted for these three templates:

However, we won't be able to solve this easily unfortunately as we would have to diverge from the way how Moodle Core composes its HTML page from multiple mustache templates and adds the language from the output.htmlattributes template context.

wiebkemueller-hsh commented 8 months ago

needs status on hold to be waited