search

moodle-an-hochschulen / moodle-theme_boost_union

Theme Boost Union is an enhanced child theme of Boost which is intended, on the one hand, to make Boost simply more configurable and, on the other hand, to provide helpful additional features for the daily Moodle operation of admins, teachers and students.
GNU General Public License v3.0
65 stars 57 forks source link

Improvement: Transfer cohort functions to Moodle core #159

Open abias opened 1 year ago

abias commented 1 year ago

This is a follow-up to #153:

In the first implementation of the flavours feature, the theme_boost_union_flavours_cohorts_is_member() function was implemented in /flavours/flavourslib.php. However, this function is not really specific to Boost Union, it just fills a gap in Moodle core's cohort library.

It would be worthwhile to transfer this function to Moodle core to /lib/cohortlib.php

christianwolters commented 1 year ago

Hi,

i did not read this, when you posted it... but implemented such a function around the same time in another plugin of mine 😅 (although, your implementation is better than mine...)

Has been a long time for me, since last contributing to core, but I'll try this : )

wiebkemueller-hsh commented 1 year ago

hey @stefanscholz I'm asking myself how the cohorts "...cohorts_is_member()" are handled in the config of the smart menu. Is this worthwile having a look at to be able to adjust this once it is backported?

christianwolters commented 1 year ago

Hi,

un-assigning myself from this. No time for now.

Cheers, Christian