Theme Boost Union is an enhanced child theme of Boost which is intended, on the one hand, to make Boost simply more configurable and, on the other hand, to provide helpful additional features for the daily Moodle operation of admins, teachers and students.
GNU General Public License v3.0
66
stars
58
forks
source link
Bug: Infobanners are sometimes incorrectly ordered if the same order is given to multiple banners #181
During the review of #167, I noticed that infobanners are sometimes incorrectly ordered if the same order is given to multiple banners and the current tests do not detect these cases.
abias
commented
1 year ago
During the review of #167, I noticed that infobanners are sometimes incorrectly ordered if the same order is given to multiple banners and the current tests do not detect these cases.
We have to change the implementation on https://github.com/moodle-an-hochschulen/moodle-theme_boost_union/blob/master/locallib.php#L414-L419 to a more robust one which includes the
noattribute of the banner into the comparison instead of relying on some internal behaviour of usort.