search

moodle-an-hochschulen / moodle-theme_boost_union

Theme Boost Union is an enhanced child theme of Boost which is intended, on the one hand, to make Boost simply more configurable and, on the other hand, to provide helpful additional features for the daily Moodle operation of admins, teachers and students.
GNU General Public License v3.0
58 stars 49 forks source link

Test: Add missing Behat tests for the H5P CSS feature #228

Open abias opened 1 year ago

abias commented 1 year ago

In https://github.com/moodle-an-hochschulen/moodle-theme_boost_union/pull/210, the H5P CSS feature was integrated without proper Behat tests. The mod_hvp plugin should be installed with GHA and tests to download and add the content types and then to test if the custom CSS is applied have yet to be written.

This issue is there to pick this up and to finish the feature's commented tests in theme_boost_union_looksettings_h5p.feature

Menrath commented 1 year ago

@abias I started work on this and should get a PR ready later today.

Menrath commented 1 year ago

I am waiting for an upstream issue in the mod_hvp package to be fixed, otherwise testing this functionality for the hvp plugin is not possible https://github.com/h5p/moodle-mod_hvp/issues/487

abias commented 6 months ago

Hi @Menrath ,

I reviewed your PR #229 and will merge it soon.

However, as you write, the scenario for testing mod_hvp is still missing.

Against this background, I have removed this code from moodle-plugin-ci.yml:

      - name: Add optional plugin dependencies
        run: |
          moodle-plugin-ci add-plugin --branch stable h5p/moodle-mod_hvp
          git -C moodle-plugin-ci-plugins/moodle-mod_hvp submodule update --init

It has to be added again when the scenario for mod_hvp is finally implemented.

abias commented 6 months ago

PS: I do not think that anything will happen on https://github.com/h5p/moodle-mod_hvp/issues/487 anytime soon. But if you could build a patch for mod_hvp and could contribute the fix to mod_hvp, you could get things moving.

abias commented 6 months ago

PR #229 has been merged now. This issue will be kept open for the remaining scenario which tests mod_hvp.