search

moodle-an-hochschulen / moodle-theme_boost_union

Theme Boost Union is an enhanced child theme of Boost which is intended, on the one hand, to make Boost simply more configurable and, on the other hand, to provide helpful additional features for the daily Moodle operation of admins, teachers and students.
GNU General Public License v3.0
58 stars 49 forks source link

Improvement: Allow flexible width for dropdown-items in more-section of course navigation #231

Closed wiebkemueller-hsh closed 1 year ago

wiebkemueller-hsh commented 1 year ago

Different lenghts of the dropdown-items in the "more"-section of the course menu lead to linebreaks where there shouldn't be line breaks, in our testsystem (Moodle 4.1.1 with Boost Union 4.1.r.2. )

Using the dev-tools in the browser we found out that overflow-wrap and white-space are responsible for this.

dev_tools_broken

dev_tools_repaired

However, we tested this on the qa-moodle site (https://qa.moodledemo.net) running Moodle 4.2 where the menu displays the items correctly without the line breaks. Here, the white space attribute has a different value nowrap, the others aren't in use.

qa_whitespace_no-wrap

My question is: Is this a behaviour the boost union theme should pick up or is this merely related to core?

BR Wiebke

lucaboesch commented 1 year ago

Dear Wiebke IMHO this is no Boost Union bug but a Moodle Core issue: https://tracker.moodle.org/browse/MDL-76947

lucaboesch commented 1 year ago

In my theme, I've added

.tertiary-navigation-selector .dropdown-item:not(.text-truncate),
#moreactionsmenu .dropdown-item:not(.text-truncate) {
    white-space: nowrap; /* Let's keep it like in Moodle 4.0 and revert MDL-76607 */
}

by the way. You might try that!

wiebkemueller-hsh commented 1 year ago

Thank you! I did try to find related issues in the moodle tracker, but apparently used the wrong keywords in my search to find this one...

lucaboesch commented 1 year ago

MDL-76947 is now in the newest releases.