search

moodle-an-hochschulen / moodle-theme_boost_union

Theme Boost Union is an enhanced child theme of Boost which is intended, on the one hand, to make Boost simply more configurable and, on the other hand, to provide helpful additional features for the daily Moodle operation of admins, teachers and students.
GNU General Public License v3.0
66 stars 58 forks source link

Navbar colour setting - Edit mode indicator #235

Closed james-pearce-bath-ac closed 1 year ago

james-pearce-bath-ac commented 1 year ago

With the nagar colour options set to 'Primary color navbar with light font color' the edit mode indicator isn't very clear when set to on. The 'on' state uses the same primary colour as the colour to be used for the navbar background and so it isn't obvious that the edit mode is on.

Example images below, our primary colour is a dark blue. Edit mode off edit-mode-off Edit mode on edit-mode-on

Maybe adding a setting for the edit mode setting on background colour could resolve this issue and may be useful when not using Navbar colours as the setting could be used to specifically highlight the edit mode as a potential warning to users.

This issue isn't particularly critical but may offer some accessibility improvements.

abias commented 1 year ago

Hi @james-pearce-bath-ac ,

many thanks for highlighting this issue.

In Moodle core, the edit switch uses the brand color as background color as soon as it is activated: grafik grafik

We already made some small modifications to the edit switch within the dark navbar patch, but I have to admit that it was focused on the dark (grey) navbar and not the brand color navbar and it might have been too short-sighted.

I think for now we should just remove the brand color background from the edit switch on dark navbars: grafik grafik

grafik grafik

grafik grafik

That way, we will loose the highlight effect of the edit switch when editing is on, but it will be better as it is now anyway.

I will set up a PR for this fix soon.

abias commented 1 year ago

@james-pearce-bath-ac - I have created a PR on https://github.com/moodle-an-hochschulen/moodle-theme_boost_union/pull/237.

If you have any chance, please give it a test-drive to see if I forgot any glitch which you have spotted.

abias commented 1 year ago

237 was merged now -> Closing.