search

moodle-an-hochschulen / moodle-theme_boost_union

Theme Boost Union is an enhanced child theme of Boost which is intended, on the one hand, to make Boost simply more configurable and, on the other hand, to provide helpful additional features for the daily Moodle operation of admins, teachers and students.
GNU General Public License v3.0
58 stars 49 forks source link

Bug: Footer placement in different templates #241

Closed JayBraker closed 1 year ago

JayBraker commented 1 year ago

Hi,

I came across something odd while styling a custom page:

Placement of the footer elements is not consistent across columns and drawers template: drawers.mustache columns2.mustache

The prior places the footer inside the page container, but the latter places it inside the page-wrapper container.

This led to some confusion an I would hope for a consistent page structure.

Was the decision made deliberately?

abias commented 1 year ago

Hi @JayBraker ,

thanks for asking.

I think you should not compare drawers.mustache and columns2.mustache. You should compare the Boost Union mustache files with the upstream mustache files from Boost Core.

Then, you will see that both in drawers and columns2, Boost Union replaces

{{> theme_boost/footer }}

with 

{{> theme_boost_union/footer }}
{{> theme_boost_union/footnote }}

but leaves these items exactly where they were before in the DOM.

This leads to the conclusion that the decision to place the footer elements at a different place in drawers and columns2 were not made by us, they were made by the Moodle core developers.

Having said that, I have to highlight that we modified columns2 just for backwards-compatibility reasons and just quickly tested if a page rendered with columns2 does not break completely. Boost Core still ships with colums2, but does not use it anywhere anymore (see https://github.com/moodle/moodle/blob/master/theme/boost/config.php). It's my understanding that it is just there if any plugin and child-theme still wants to render a page with this layout.

Did that help?

JayBraker commented 1 year ago

Hey @abias

thanks for elaborating on that decision.

Did help alot!

Kind regards