search

moodle-an-hochschulen / moodle-theme_boost_union

Theme Boost Union is an enhanced child theme of Boost which is intended, on the one hand, to make Boost simply more configurable and, on the other hand, to provide helpful additional features for the daily Moodle operation of admins, teachers and students.
GNU General Public License v3.0
66 stars 58 forks source link

Bug: (Future) config.php sets editor_scss but has no editor.scss, and Boost's editor.scss will never be loaded #242

Closed danowar2k closed 1 year ago

danowar2k commented 1 year ago

Mainly a potential minefield for the future, if Boost ever decides to change the contents of its editor.scss file, see https://github.com/moodle/moodle/blob/MOODLE_401_STABLE/theme/boost/scss/editor.scss

boost_union sets editor_scss, see https://github.com/moodle-an-hochschulen/moodle-theme_boost_union/blob/master/config.php#L30

Moodle core works like this: https://github.com/moodle/moodle/blob/MOODLE_401_STABLE/lib/outputlib.php#L1020

If a theme sets editor_scss, Moodle looks for the files in the theme and loads them. If they aren't present, there's only a a debugging message, see https://github.com/moodle/moodle/blob/MOODLE_401_STABLE/lib/outputlib.php#L1051

Other editor_scss properties from parent themes aren't respected because boost_union sets it.

This is not a problem because Boost's editor.scss at the moment is pretty empty and redundant, but if Boost ever changes that, boost_union would ignore these scss file changes.

danowar2k commented 1 year ago

Here you are: https://github.com/moodle-an-hochschulen/moodle-theme_boost_union/pull/243

abias commented 1 year ago

This was solved in #243 243