search

moodle-an-hochschulen / moodle-theme_boost_union

Theme Boost Union is an enhanced child theme of Boost which is intended, on the one hand, to make Boost simply more configurable and, on the other hand, to provide helpful additional features for the daily Moodle operation of admins, teachers and students.
GNU General Public License v3.0
66 stars 58 forks source link

Overwrite Modules purpose #288

Closed goggo24 closed 1 year ago

goggo24 commented 1 year ago

Because we do not agree with every classification of the purpose or because some third-party plugins do not currently support it, we've implemented an adminsetting, to overwrite the purpose of plugins. In our child theme all installed modules are listed with their default purpose. If a plugin hasn't set a purpose "other" is default. As admin now you have the possibility to overwrite the purpose without any need of patching the plugin himself.

grafik

If you think, it's helpful - we can make a PR in the next weeks to integrate it in boost union.

Regards, Eva K (AMC)

abias commented 1 year ago

This was solved in #308 as a MoodleMootDACH DevCamp result :)

tjettmers commented 1 year ago

Hi @abias and @goggo24, we just updated Boost Union and maybe there is an unnoticed issue. If I change the purpose of an activity, everything looks fine on the coursepage: image But if I click on the (purpose-changed) activity, it is displayed with the old color: image

Regarding the source of the code, I am not sure, if this already has been a problem in Vienna or the problem comes with the integration into Boost Union "core".

Edit: This could be connected with https://github.com/moodle-an-hochschulen/moodle-theme_boost_union/issues/318 or even identical with it.

goggo24 commented 1 year ago

Hey, we also had the error and it was fixed - because Alex only got a Zip file, maybe the latest changes haven't been included. I will have a look for the commit. In our childtheme it works for the course and activity level.

goggo24 commented 1 year ago

@abias how shall we proceed? The commit on 26.05 and 29.05 should fix the problem

Screenshot from 2023-06-22 16-19-14

abias commented 1 year ago

Hi @tjettmers and @goggo24 ,

thanks for raising this additional issue and for providing a bugfix. However, this issue is closed now. But I also think that this issue is already reported on #318.

I will transfer your bugfix to this issue and will try to solve it there.

Thanks, Alex