search

moodle-an-hochschulen / moodle-theme_boost_union

Theme Boost Union is an enhanced child theme of Boost which is intended, on the one hand, to make Boost simply more configurable and, on the other hand, to provide helpful additional features for the daily Moodle operation of admins, teachers and students.
GNU General Public License v3.0
58 stars 49 forks source link

Test: Add Behat scenario to test FontAwesome feature #296

Open abias opened 1 year ago

abias commented 1 year ago

The FontAwesome feature is currently not covered with Behat tests:

https://github.com/moodle-an-hochschulen/moodle-theme_boost_union/blob/master/tests/behat/theme_boost_union_looksettings_resources.feature#L58-L59 says:

# Unfortunately, this can't be tested with Behat yet as the 'And I upload file to filemanager' step does not support folders
# Scenario: Setting: FontAwesome - Upload FontAwesome files

Meanwhile, #209 was integrated with a simple approach to upload folders indeed manually: See https://github.com/moodle-an-hochschulen/moodle-theme_boost_union/blob/master/tests/behat/theme_boost_union_looksettings_branding.feature#L171-L199

Using this approach as boilerplate, the FontAwesome feature could covered with a simple Behat test as well.

abias commented 10 months ago

From Moodle 4.2 on, FontAwesome 6 free is part of Moodle core. This means that the scope of this issue is for 4.1 only anymore.