search

moodle-an-hochschulen / moodle-theme_boost_union

Theme Boost Union is an enhanced child theme of Boost which is intended, on the one hand, to make Boost simply more configurable and, on the other hand, to provide helpful additional features for the daily Moodle operation of admins, teachers and students.
GNU General Public License v3.0
66 stars 58 forks source link

Test: Align smart menu test with the smart menu item test for css classes #367

Closed abias closed 8 months ago

abias commented 1 year ago

This is a follow-up issue to #300.

The https://github.com/moodle-an-hochschulen/moodle-theme_boost_union/blob/f5d593275c6ec4e8d2e446e3f82a51823e2f6e87/tests/behat/theme_boost_union_menuitemsettings_application.feature#L168 test tests the css classes for menu items in all smart menu areas (Main, User, Bottom, Menubar), but the corresponding test https://github.com/moodle-an-hochschulen/moodle-theme_boost_union/blob/f5d593275c6ec4e8d2e446e3f82a51823e2f6e87/tests/behat/theme_boost_union_menusettings_application.feature#L151 for menus does only test the main navigation.

It would be worthwhile to align the menu test with the menu item test.

abias commented 8 months ago

This was solved some time ago by #501