search

moodle-an-hochschulen / moodle-theme_boost_union

Theme Boost Union is an enhanced child theme of Boost which is intended, on the one hand, to make Boost simply more configurable and, on the other hand, to provide helpful additional features for the daily Moodle operation of admins, teachers and students.
GNU General Public License v3.0
65 stars 58 forks source link

Release: Fix columns2 and drawers mustache linter warnings #454

Closed abias closed 8 months ago

abias commented 1 year ago

If you look at a recent GHA run on https://github.com/moodle-an-hochschulen/moodle-theme_boost_union/actions, you will notice that there are several mustache linter warnings which target the columns2.mustache and drawers.mustache templates:

/home/runner/work/moodle-theme_boost_union/moodle-theme_boost_union/moodle/theme/boost_union/templates/theme_boost/columns2.mustache - WARNING: ESLint error [no-trailing-spaces]: Trailing spaces not allowed. ( }); ), Line: 12 Column: 1

/home/runner/work/moodle-theme_boost_union/moodle-theme_boost_union/moodle/theme/boost_union/templates/theme_boost/drawers.mustache - WARNING: ESLint error [no-trailing-spaces]: Trailing spaces not allowed. ( }); ), Line: 14 Column: 1
/home/runner/work/moodle-theme_boost_union/moodle-theme_boost_union/moodle/theme/boost_union/templates/theme_boost/drawers.mustache - WARNING: ESLint error [no-trailing-spaces]: Trailing spaces not allowed. ( }); ), Line: 15 Column: 1

In contrast to some other warnings in the output, these three warnings are not duplicated from the corresponding *.upstream template files. Thus, they must be caused by some addition of Boost Union to these templates.

However, the reason is unclear at first sight.

abias commented 8 months ago

These warnings are not there anymore now. I think this issue was solved recently within 293cae5ca35b7119904c0b4c43ca93f7dae2113f