Bug: OAuth2 login button does not have a background image - Githubissues

moodle-an-hochschulen / moodle-theme_boost_union

Theme Boost Union is an enhanced child theme of Boost which is intended, on the one hand, to make Boost simply more configurable and, on the other hand, to provide helpful additional features for the daily Moodle operation of admins, teachers and students.

GNU General Public License v3.0

61 stars 56 forks source link

Bug: OAuth2 login button does not have a background image #473

Closed abias closed 10 months ago

abias commented 10 months ago

Steps to reproduce:

Login as admin
On /admin/tool/oauth2/issuers.php, add an OAuth2 provider which can be used for login
On /admin/settings.php?section=manageauths, enable the OAuth2 auth plugin
Enable thetheme_boost_union | loginformtransparency setting
Upload a login background image to theme_boost_union | loginbackgroundimage
Logout
Go to the login page

Expected result:

The OAuth2 Login button is readable

Actual result:

The OAuth2 Login button is transparent and not readable

Analysis:

On https://github.com/moodle/moodle/blob/master/lib/templates/loginform.mustache#L168, the OAuth2 button in the login form is not given a btn-* class which adds a background color.
Boost Union should override this template and add a btn-secondary class to these login buttons.

abias commented 10 months ago

This was solved in #478