moodle-an-hochschulen / moodle-theme_boost_union

Theme Boost Union is an enhanced child theme of Boost which is intended, on the one hand, to make Boost simply more configurable and, on the other hand, to provide helpful additional features for the daily Moodle operation of admins, teachers and students.
GNU General Public License v3.0
61 stars 56 forks source link

Bug: The "Mark external links" setting might clash with the "Share progress to MoodleNet" feature #527

Open abias opened 9 months ago

abias commented 9 months ago

The "Share progress to MoodleNet" feature adds an i/externallink icon to the page somewhere - see https://github.com/moodle/moodle/blob/aeb64dbfb5f80767b9ad1102a60205fcccd0dade/lib/classes/moodlenet/share_progress_table.php#L128.

This icon might clash with Boost Union's "Mark external links" setting.

Unfortunately, I was not able to enable this MoodleNet feature yet, so I am neither able to provide a screenshot nor to provide a fix which could be added to the theme_boost_union_get_scss_to_mark_external_links() function on https://github.com/moodle-an-hochschulen/moodle-theme_boost_union/blob/master/locallib.php#L1399