feat: show course module icons in course index, resolves #16

[christianwolters]

Hi,

I'll adress grunt and codechecker asap.

Cheers Christian

[lucaboesch]

Thanks for your proposal, @christianwolters !

Allow me some thoughts about your work. You offer two options which are carefully programmed for. From default to the left hand side to "End of line" (middle) and "Icon" (right)

Now, for me there are options left out, and I don't know whether because it is impossible to accomplish or why else but I'd like to mix them into the game. That would be (default to the left hand side again) "Start of line" which also could be called "in front of the icon" (middle) and "after the icon" (right)

So, in the end, the four options could be: "in front of the icon", "after the icon", "end of line", and "colour in the icon".

What do you think?

Best, Luca

[christianwolters]

Hi @lucaboesch,

thanks for taking the time to look at this.

Regarding the "left out" options:

• my approach was to deliver a first step into course-index manipulation in boost union
• the options provided for the completion indication were the first that came to my mind
• personally, displaying icon and completion circle side-by-side is a bit crowded (but that is really IMHO)

That being said, I like the idea of offering more display options (and also i really like your option naming: "in front of the icon", "after the icon", "end of line", and "colour in the icon").

Right now, I'm thinking that these options could be implemented, but there is certainly a need for some thinking and refactoring, which would block this PR.

So I'd like to move your ideas into a new issue, so they become the next iteration of this feature?

Cheers Christian

[lucaboesch]

Yes, sure, it is very welcome to add the two other options as follow-up issues. It is unlikely they would have been in in time for our upgrade February 14th, 2024, anyway 😜.

[abias]

Hi @christianwolters , many thanks for contributing this feature!

And thanks @lucaboesch for your initial thoughts!

I have now taken this over and made an integration review.

Doing this:

• I have raised version in version.php (as you have introduced new settings)
• I added a note to CHANGES.md
• I added a section to README.md
• I improved the overall coding style and verbosity
• I reverted some indention changes in the duplicated mustache templates to shrink the diff between the BU template and the upstream template
• I fixed the example context in cm.mustache
• I fixed the drag icon in edit mode (which you broke unfortunately)
• I improved the alignment of the activity icons in connection with the section titles
• I added an icon style for dimmed / inactive activities
• I added the option "in front of the icon" as Luca suggested it (I just had to ignore "after the icon" for now due to time constraints)
• I have extended the Behat tests and have transformed it into a Scenenario outline. It's not perfect, as this patch has massive visual impact which can't be tested with Behat, but it should be fine for the time being.

Unfortunately, I was not able to push my review changes to your fork @christianwolters.

That's why I will close this PR now and will create a follow-up PR on #562.

Cheers, Alex