Course index using cards, resolves #558

[danielneis]

This displays the courses on /course using cards like the ones in the dashboard. This code was copied and adapted from the Moove theme. It was tested on Moodle 4.3

[christianwolters]

Hi @danielneis,

thank you for contributing and your work on this PR.

Our process is centered around the project board under: https://github.com/orgs/moodle-an-hochschulen/projects/4/views/1 which needs an issue for every PR.

Please create a Github issue using one of the provided templates.

As you have already done the coding work, feel free to provide some screenshots.

Cheers Christian

[danielneis]

Hello, I've created #558 for this

[kaaermes]

Hi @danielneis

thank for your work on this pr but we have some additional questions/tasks for you

Could you offer this feature as an add on, that means we need an on/off switch so that initially nothing changes when installing this feature, but if the admin wants to he/she could turn it on.

Some additional settings would be also nice: shorten the length of the text e.g.

And please note that the overall design should match the bootsrap standard (no shadows and so on).

Cheers, Kathleen

[snack753]

If this feature get a switch to be able to turn it on or off, I would still recommend an improvement for the "off" state: The courses in the category overview get listed without separators. This little CSS addon shows every coursebox a bit separated from each other, making it easier to distinguish the courses from each other:

.coursebox { border: #eeeeee !important; border-style: solid !important; border-radius: 10px; margin-bottom: 10px; }

The code was tested in the RAW SCSS area of my moodle installation and makes a bit improvement for my site. The color code shall ideally be taken from the predefined colors.

[christianwolters]

Hi @snack753,

thank you for your suggestion.

As you mentioned yourself, your suggestion does not cover the feature of this PR but the default state of Boost Union which has to be discussed separately.

Please open a new issue for your suggestion: https://github.com/moodle-an-hochschulen/moodle-theme_boost_union/issues/new/choose so we can move the discussion there.

Cheers Christian

[lucaboesch]

Also, a picture is worth a thousand words. I would have appreciated a screenshot. Or maybe two, one 'before', one 'after'.

[kaaermes]

Also, a picture is worth a thousand words. I would have appreciated a screenshot. Or maybe two, one 'before', one 'after'.

Hi @lucaboesch, hi all > I can provide a screenshot "courses as cards"

[snack753]

Hi Christian,

no problem. I created the feature request #573 including screenshots.

Cheers, Kai

[kaaermes]

Hi @danielneis

quick reminder: did you noticed my comment three weeks ago?

Can you give us an answer to our questions and comments?

thanks, Kathleen

[danielneis]

Hi @kaaermes , Yes, I'll work on this issue this wednesday and update the pull request. Best, Daniel

[danielneis]

Hi! I've made it an optional setting, disabled by default.

Default page:

Page with cards and teachers pictures:

Page with cards and without teachers pictures:

To shorten the summary I would need to change the get_course_formatted_summary method from coursecat_helper.

Please, let me know if you need anything else from my side.

Best, Daniel

[danielneis]

I've removed the use of theme->settings

[kaaermes]

Hi @danielneis

thank you for your work but we have still some issue:

the presentation of text is not quite good yet – long texts don't look good

We have some ideas – maybe you can think about them:

1) you integrate a hard limitation of character lenght 2) you use a max height for the cards and the use can scroll through the text 3) texts will be shorten and you integrate a collapse element

Please let us know if it's possible for you to adapt one of these. :-)

Kathleen

[danielneis]

Hello,

I've opted for the maximum height with scroll on overflow because it's the simplest code and yet allows the user to read the full summary if he/she/they want to.

Please, let me know if you need me to change the maximum height or anything else.

Best, Daniel

[luiggisanso]

Hi team and @danielneis

Have you considered also a course field zone ?

It could be great too ;-)

[danielneis]

Yes, course custom fields are displayed before the course summary:

[kaaermes]

Hi @danielneis

we want to invite you to a team session via matrix/elements. Could you please check your matrix chat for that?

thx, Kathleen

[danielneis]

hi!

There are two invites: Stefan-Alexander Scholz Wiebke Muller

Shouls I accept both?

Best,

Em qua., 10 de abr. de 2024 07:05, Kathleen Aermes @.***> escreveu:

Hi @danielneis https://github.com/danielneis

we want to invite you to a team session via matrix/elements. Could you please check your matrix chat for that?

thx, Kathleen

— Reply to this email directly, view it on GitHub https://github.com/moodle-an-hochschulen/moodle-theme_boost_union/pull/555#issuecomment-2047110554, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAEJSHD2W2XRI2A7X3EBULY4UFF5AVCNFSM6AAAAABC6KF74KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANBXGEYTANJVGQ . You are receiving this because you were mentioned.Message ID: <moodle-an-hochschulen/moodle-theme_boost_union/pull/555/c2047110554@ github.com>

[kaaermes]

Hi @danielneis

yes – you are welcome to accept both :-)

[HsH-Wolf]

This PR ist now ready for review with special attention for the following topics:

• placement of the admin settings in a fitting category/tab
• spacing (before and after course category and teachers names)
• breakpoints for responsive view

[danielneis]

Hello! If there is anything I could do to help this being merged, please, let me know. Best, Daniel