search

moodle-an-hochschulen / moodle-theme_boost_union

Theme Boost Union is an enhanced child theme of Boost which is intended, on the one hand, to make Boost simply more configurable and, on the other hand, to provide helpful additional features for the daily Moodle operation of admins, teachers and students.
GNU General Public License v3.0
55 stars 49 forks source link

Moodle 403 load custom field config fix, resolves #576 #579

Closed SimonThornett closed 4 months ago

SimonThornett commented 4 months ago

On behalf of the Boost Union Team: 🎉 Thank you for contributing! 🎉

Please note: There must be a GitHub issue for every pull request (PR)

We kindly ask you to create a github issue now if you haven't already done so.

Please make sure to follow these steps to ease the review process for the peer review team:

[ ] link your issue in the PR title, using the keyword 'resolves #ISSUE-NUMBER', e.g. 'feat: provide the ultimate user experience, resolves #42' [ ] provide any further information that is relevant for peer review and not yet mentioned in the linked issue [ ] submit your PR in draft status to run the automated checks and review the results [ ] in case any checks fail solve the mentioned errors by pushing the corrected code to your PR-branch [ ] if all checks pass (or if you are unable to resolve the failing steps without any help of the review team), mark the PR as 'ready for review' [ ] make sure that the 'Allow edits by maintainers' checkbox is checked when creating the PR. Otherwise, the peer reviewer would not be able to push any review changes to the PR and the communication overhead increases

Thank you again for your contribution, we will start reviewing your PR as soon as we are able to.

Feel free to check our wiki for further infomation about our review process.

lucaboesch commented 4 months ago

@SimonThornett it's okay (and it's the idea) to make a pull request merely to master. The developer then take care of porting it to the maintained stable versions. Thanks for your work!

SimonThornett commented 4 months ago

Apologies @lucaboesch, I'll keep that in mind for the future. Please let me know if you need me to create a new request for master instead

lucaboesch commented 4 months ago

Yes, @SimonThornett, please create a new one. Also, not what I commented here https://github.com/SimonThornett/moodle-theme_boost_union/commit/91168a232a47fec66976055f475faa906e732275#r139254311.