search

moodle-an-hochschulen / moodle-theme_boost_union

Theme Boost Union is an enhanced child theme of Boost which is intended, on the one hand, to make Boost simply more configurable and, on the other hand, to provide helpful additional features for the daily Moodle operation of admins, teachers and students.
GNU General Public License v3.0
55 stars 49 forks source link

Fix: More menu "keep outside of more menu" doesn't show any effect, resolves #461 #580

Closed prasanna-lmsace closed 1 month ago

abias commented 2 months ago

@prasanna-lmsace ,

to clarify and visualize my findings, please see the following screenshots from my Behat runs. The Smartmenu: Menus: Presentation - Display the menus inside and outside more menu (Looking at the visible menus in the main menu) and the Smartmenu: Menus: Presentation - Display the menus inside and outside more menu (Looking at the visible menus in the menu bar) scenarios which I added are design in a way that each scenario should show two menus on tablet screens and the third menu should fall into the More menu.

However, in two of the four examples only one menu is shown even though enough space is available and the menu configuration is correct:

Configuring-the-theme_boost_union-plugin-on-the-Smart-menus-page-applying-different-presentation-options-to-the-individual-smart-menus_I-should-see-0-0-0-_boost_union_243

Configuring-the-theme_boost_union-plugin-on-the-Smart-menus-page-applying-different-presentation-options-to-the-individual-smart-menus_I-should-see-1-0-0-_boost_union_243

Configuring-the-theme_boost_union-plugin-on-the-Smart-menus-page-applying-different-presentation-options-to-the-individual-smart-menus_I-should-see-0-0-2-_boost_union_243

Configuring-the-theme_boost_union-plugin-on-the-Smart-menus-page-applying-different-presentation-options-to-the-individual-smart-menus_I-should-see-0-1-2-_boost_union_243

prasanna-lmsace commented 2 months ago

Hi @abias

Thank you for providing the screenshots and describing the issue with the Smart menu. We've reviewed the scenarios you mentioned, and understand the issue.

We'll work on fixing this issue as soon as possible and keep you updated on our progress.

Thanks! Prasanna

prasanna-lmsace commented 2 months ago

Hi @abias

We've thoroughly reviewed the comments and discovered that the mentioned issues are inherent to Moodle's default behavior. We've replicated the same behavior using the Boost theme with custom menu items.

It appears that the More menu hides additional menu items even when there's some space available.

While this behavior isn't specific to Boost Union, we're more than willing to address this issue within the smart menu. Please confirm if you'd like us to proceed with fixing it.

Thanks, Prasanna

abias commented 1 month ago

Thank you @prasanna-lmsace your for additional information. I was not aware that this behaviour exists already in Moodle core, but I can confirm your finding now. I do not think that it's the right time to fix this glitch in Boost Union now. Instead, I have reported the bug upstream at https://tracker.moodle.org/browse/MDL-81892 and would like to wait some time to see if someone picks it up there.

Regarding this PR here, I will try to modify the Behat scenarios in a way that they respect the current Moodle core behaviour and still test the Boost Union feature.