search

moodle-an-hochschulen / moodle-theme_boost_union

Theme Boost Union is an enhanced child theme of Boost which is intended, on the one hand, to make Boost simply more configurable and, on the other hand, to provide helpful additional features for the daily Moodle operation of admins, teachers and students.
GNU General Public License v3.0
55 stars 49 forks source link

Load custom field config fix, resolves #576 #581

Closed SimonThornett closed 3 months ago

SimonThornett commented 4 months ago

On behalf of the Boost Union Team: 🎉 Thank you for contributing! 🎉

Please note: There must be a GitHub issue for every pull request (PR)

We kindly ask you to create a github issue now if you haven't already done so.

Please make sure to follow these steps to ease the review process for the peer review team:

[ ] link your issue in the PR title, using the keyword 'resolves #ISSUE-NUMBER', e.g. 'feat: provide the ultimate user experience, resolves #42' [ ] provide any further information that is relevant for peer review and not yet mentioned in the linked issue [ ] submit your PR in draft status to run the automated checks and review the results [ ] in case any checks fail solve the mentioned errors by pushing the corrected code to your PR-branch [ ] if all checks pass (or if you are unable to resolve the failing steps without any help of the review team), mark the PR as 'ready for review' [ ] make sure that the 'Allow edits by maintainers' checkbox is checked when creating the PR. Otherwise, the peer reviewer would not be able to push any review changes to the PR and the communication overhead increases

Thank you again for your contribution, we will start reviewing your PR as soon as we are able to.

Feel free to check our wiki for further infomation about our review process.

SimonThornett commented 4 months ago

New pull request for master as requested by @lucaboesch in pull 579 with requested changes.

abias commented 3 months ago

Hi @SimonThornett ,

many thanks for contributing this bugfix! I remember doing something similar in our plugin tool_coursefields, but we did not remember this glitch when implementing the smart menu configuration.

I just pushed a "Review changes" commit on top of your branch to make the comments slightly more verbose, to add an entry to CHANGES.md and to add your credits to the README.md.

I will merge the PR as soon as the tests are green again.

Cheers, Alex

SimonThornett commented 2 months ago

Hi @abias,

Cheers for this (and the amends). Apologies for not replying sooner, I have been unavailable for some time. I also wanted to convey the thanks from our partner for the speed in which you got this added.

Kind regards, Simon