Upgrade: Boost Union settings were moved to an admin settings category of its own to support the new theme chooser on Moodle 4.4, refines #482

moodle-an-hochschulen / moodle-theme_boost_union

Theme Boost Union is an enhanced child theme of Boost which is intended, on the one hand, to make Boost simply more configurable and, on the other hand, to provide helpful additional features for the daily Moodle operation of admins, teachers and students.

GNU General Public License v3.0

55 stars 49 forks source link

Upgrade: Boost Union settings were moved to an admin settings category of its own to support the new theme chooser on Moodle 4.4, refines #482 #612

Closed abias closed 2 months ago

abias commented 3 months ago

I refined the PR #609.

There is now a Boost Union settings overview page which looks like this:

On Moodle 4.4dev, it is linked from the theme selector:

and the Appearance page only has the new Boost Union settings category:

On Moodle 4.3, it is linked from the "Boost Union" link which is still auto-generated by Moodle core:

I hope that this is a good compromise between a forward-facing fix for Moodle 4.4 and a not-so-big chance for 4.3 and older Moodle releases.

abias commented 3 months ago

The tests have passed (the codechecker just fails because of https://github.com/moodlehq/moodle-cs/issues/142 which is out of our scope).

@lucaboesch - may I ask you to have a look at this PR if you have time?

lucaboesch commented 3 months ago

This page looks brilliant, @abias. I understand it might make Behat testing easier if the entries still would exist in 4.4 but I think they should be omitted and the Behat tests rewritten to work with both version. Here's how the adding to the settings could be omitted given the Theme selector page already exists: https://github.com/lucaboesch/moodle-theme_boost_union/tree/issue-482

abias commented 3 months ago

Based on an internal discussion, I have added another panel which links to the settings category page:

Beyond that, my gut feeling is that we should integrate this PR now and postpone discussions how to further improve the settings structure and settings navigation into follow-up issues.

abias commented 2 months ago

This PR has been discussed internally and is merged now. A follow-up issue has been created on #621