search

moodle-an-hochschulen / moodle-theme_boost_union

Theme Boost Union is an enhanced child theme of Boost which is intended, on the one hand, to make Boost simply more configurable and, on the other hand, to provide helpful additional features for the daily Moodle operation of admins, teachers and students.
GNU General Public License v3.0
68 stars 60 forks source link

Tab-Index for Smart Menus #619

Open create-martin opened 7 months ago

create-martin commented 7 months ago

Describe the bug So, some of our clients put a very (very) high focus on accessibilty. In one of those projects we're using smart menus.

BUT, if I use the Tabulator to navigate the page, it moves quickly to "Dashboard" (the moodle core main navigation) but from there it DOES NOT move on the the smart menu entries (but goes to the content instead).

This is not expected behaviour, since we would like to navigate through all main navigation entries at once.

As far as we tested, smart menu entries are more or less the last thing on the page, when using Tabulator...

This actually has a very high priority for us - and is hopefully an easy fix??

To Reproduce Steps to reproduce the behavior: Just create a smart menu entry and try navigating to it using the Tabulator

Expected behavior All main navigation entries (incl. those injected by smartmenus) can be navigated one after the other

create-martin commented 4 months ago

any estimate, when this will be officially released?

abias commented 1 week ago

Hi @create-martin ,

thank you very much for raising this issue. I am sorry that it has remained unhandled up to now.

Disclaimer: We do not have an accessibility expert in our Boost Union team, we are just doing our best not to break the existing accessibility of Moodle core with Boost Union. Against this background, we are grateful for all accessbility advices.

Having read through your issue report and having made some tests with a plain Moodle core installation, with the custom menus from Moodle core and with Boost Union's smart menus, I am wondering what exactly you are asking for.

Boost Union's smart menus are more or less added to the page in the same way as the custom menus are added. This means that they should adopt all accessibility features and flaws from the custom menus.

My understanding of the tab index in Moodle (core) is that the user should not tab through the main navigation (Home, Dashboard, My courses, Site administration) one item after the other. This is because all main navigation items have the same tabindex. The user should just tab "into" the main navigation which has tabstop number 3 according to Firefox' accessibility tools:

grafik

But as soon as the user has tabbed into the main navigation, he can use the arrow keys to navigate inside the main navigation. This is realized by moving the focus between the individual menu items and is highlighted with the blue focus frame:

grafik

As smart menu items are added to the page just like normal main menu items, they are covered by this existing mechanism. The user can even navigate into submenus by pressing the down arrow:

grafik

Having said that, I would not assess this issue here as a smart menu bug anymore unless you prove me wrong.

On the other hand, there is already a pull request on #641 which realizes more or less what you are asking for. I would like to review this anytime soon now, but I would appreciate to have your reasoning before I review it.

Cheers, Alex

create-martin commented 5 days ago

Hi Alex,

hm, I think you’re right. Tabbing INTO the main navigation and then using arrow keys to switch between the menu items is sufficient. I was talking with my team again, why we’ve raised this issue, but honestly, we’re not sure anymore. Our current clients seem to be fine with the existing functionality. At least, thats the feedback I got internally.

Thanks for bringing it to my attention again – I think you can close that one as „unresolved“.

If it pops up again, I’ll let know, if there are any good reasons for doing it differently😊

All the best, Martin

[CREATE] Wir leben Lernen. [Facebook]https://www.facebook.com/CREATE.Digital.Learning [LinkedIn] https://www.linkedin.com/company/758246?trk=tyah&trkInfo=idx%3A1-1-1%2CtarId%3A1425468563071%2Ctas%3Acreate+mediadesign [CREATE] https://www.create.at/ [cBook] http://www.cbook.de/ create-mediadesign GmbH ATU 50420904 | HG Wien-FN 201256s Wien: A-1040 | Taubstummengasse 7/3 München: 81375 | Würmtalstraße 20 A DI(FH) Martin Berger Senior Technical Consultant | DSB [E-Mail:] @.**@.> [Tel.:] +43 1 78 66 318 22<tel:+431786631822> [Web:] create.athttps://create.at/ | cBook.dehttp://www.cbook.de

For a better 21st century.

Von: Alexander Bias @.> Gesendet: Montag, 18. November 2024 13:41 An: moodle-an-hochschulen/moodle-theme_boost_union @.> Cc: Martin Berger @.>; Mention @.> Betreff: Re: [moodle-an-hochschulen/moodle-theme_boost_union] Tab-Index for Smart Menus (Issue #619)

Hi @create-martinhttps://github.com/create-martin ,

thank you very much for raising this issue. I am sorry that it has remained unhandled up to now.

Disclaimer: We do not have an accessibility expert in our Boost Union team, we are just doing our best not to break the existing accessibility of Moodle core with Boost Union. Against this background, we are grateful for all accessbility advices.

Having read through your issue report and having made some tests with a plain Moodle core installation, with the custom menus from Moodle core and with Boost Union's smart menus, I am wondering what exactly you are asking for.

Boost Union's smart menus are more or less added to the page in the same way as the custom menus are added. This means that they should adopt all accessibility features and flaws from the custom menus.

My understanding of the tab index in Moodle (core) is that the user should not tab through the main navigation (Home, Dashboard, My courses, Site administration) one item after the other. This is because all main navigation items have the same tabindex. The user should just tab "into" the main navigation which has tabstop number 3 according to Firefox' accessibility tools:

grafik.png (view on web)https://github.com/user-attachments/assets/c8f07f9a-67bb-42b4-9b1a-ad6e3d8f09d0

But as soon as the user has tabbed into the main navigation, he can use the arrow keys to navigate inside the main navigation. This is realized by moving the focus between the individual menu items and is highlighted with the blue focus frame:

grafik.png (view on web)https://github.com/user-attachments/assets/0475a237-767a-4801-8d47-4b16a9e45a8e

As smart menu items are added to the page just like normal main menu items, they are covered by this existing mechanism. The user can even navigate into submenus by pressing the down arrow:

grafik.png (view on web)https://github.com/user-attachments/assets/773ac380-ca40-4188-bd2b-2b9fd9ea6f1b

Having said that, I would not assess this issue here as a smart menu bug anymore unless you prove me wrong.

On the other hand, there is already a pull request on #641https://github.com/moodle-an-hochschulen/moodle-theme_boost_union/pull/641 which realizes more or less what you are asking for. I would like to review this anytime soon now, but I would appreciate to have your reasoning before I review it.

Cheers, Alex

— Reply to this email directly, view it on GitHubhttps://github.com/moodle-an-hochschulen/moodle-theme_boost_union/issues/619#issuecomment-2482931646, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAIDDXBMPQURO25WH5ZMP5D2BHN43AVCNFSM6AAAAABFVLETOSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIOBSHEZTCNRUGY. You are receiving this because you were mentioned.Message ID: @.**@.>>

Diese E-Mail kann vertrauliche und/oder rechtlich geschützte Informationen enthalten. Wenn Sie nicht der beabsichtigte Adressat sind, oder diese E-Mail irrtümlich erhalten haben, informieren Sie bitte den Absender und löschen Sie diese E-Mail. Das unerlaubte Kopieren sowie die unbefugte Weitergabe dieser E-Mail und der darin enthaltenen Informationen sind nicht gestattet.