search

moodle-an-hochschulen / moodle-theme_boost_union

Theme Boost Union is an enhanced child theme of Boost which is intended, on the one hand, to make Boost simply more configurable and, on the other hand, to provide helpful additional features for the daily Moodle operation of admins, teachers and students.
GNU General Public License v3.0
55 stars 49 forks source link

First version of a flavour is used forever in theme designer mode. #625

Open monnardj opened 2 months ago

monnardj commented 2 months ago

When a flavour for a course category is modified with theme designer mode enabled, changes are not shown. Disabling theme designer mode shows the changes. When enabling theme designer mode again, changes are not shown. Purging all caches doesn't make a difference. The original flavour's settings are used "forever" in theme designer mode. This happens with Moodle 4.3 and 4.4 (others not tested).

To reproduce, try the following :

  1. Enable theme designer mode
  2. Create a flavour with some visible change (e.g. add a background image), and apply it to a course category
  3. Verify that the flavour works by entering a course in the corresponding category.
  4. Modify the flavour and remove the background image.
  5. Enter the course. The background image is still displayed.
  6. Disable theme designer mode.
  7. Enter the course. The background image is not displayed.
  8. Purge all caches.
  9. Enable theme designer mode.
  10. Enter the course. The background image is still displayed !
  11. Verify in the flavour that there is no background image.

When theme designer mode is enabled, it looks like Boost Union uses the first version of a flavour forever. Purging caches doesn't make a difference.

When working with a theme, theme designer mode is very useful, as it makes it unnecessary to purge caches to see changes. Thus, the behaviour described above is very counterintuitive (it took me some time to identify the problem !). And the fact that changes to a flavour are never shown in designer mode is a real problem.

whuml commented 2 months ago

@monnardj Thanks for reporting that bug and your detailed description, which made it easy to reproduce. We marked this as a bug to be fixed.

brgds Wolfgang