moodle-an-hochschulen / moodle-theme_boost_union

Theme Boost Union is an enhanced child theme of Boost which is intended, on the one hand, to make Boost simply more configurable and, on the other hand, to provide helpful additional features for the daily Moodle operation of admins, teachers and students.
GNU General Public License v3.0
55 stars 49 forks source link

Allow plugin icons for smartmenu items. #626

Open jrm-unamur opened 2 months ago

jrm-unamur commented 2 months ago

Hi there,

Currently the fontawesome icon-picker in smartmenu items edit form lists only fontawesome mappings from Moodle Core. It would be awesome if the icon-picker listed plugin icons too, that is icons from plugins implementing the _component_pluginname_get_fontawesome_iconmap() function.

If I'm not mistaken, this could be easily done by replacing 2 calls to $faiconsystem->get_core_icon_map() with $faiconsystem->get_icon_name_map() classes/form/smartmenu_item_edit_form.php : line 186 lib.php : line 537

Thanks for your attention

Jean-Roch

christianwolters commented 1 month ago

Hi @jrm-unamur,

thank you for pointing this out and providing a possible solution.

We'll consider fixing this.

Cheers Christian