moodle-an-hochschulen / moodle-theme_boost_union

Theme Boost Union is an enhanced child theme of Boost which is intended, on the one hand, to make Boost simply more configurable and, on the other hand, to provide helpful additional features for the daily Moodle operation of admins, teachers and students.
GNU General Public License v3.0
55 stars 49 forks source link

Issue: All sections display in course index and nothing happens when I select an item #637

Open janeesullivan opened 2 months ago

janeesullivan commented 2 months ago

We are implementing a new Moodle site, and we are having issues with the Course Index for all of the courses imported from Totara. The course index displays all of the label content: image

Whereas other themes, such as Moove and LearnR do not display labels in the Course Index: image

Also, when I click on an activity in the Course Index, nothing happens unless I have first selected the Section Title in the course index.

HsH-Wolf commented 1 month ago

Dear @janeesullivan

could you please provide the Moodle and Boost union versions, you are using, since I am not able to reproduce the bug.

Furthermore, displaying the title of the text and media area (former label) or the beginning of its content, if there is no title, is Moodle core behaviour. (You can find the description here: https://docs.moodle.org/404/en/Text_and_media_area)

Best regards on behalf of the Boost union team Yvonne

janeesullivan commented 1 month ago

Hi Yvonne,

Thanks for investigating this and providing that clarity. I think you’ve identified the problem – that we are missing a name on the I don’t actually have a ‘Name’ field for the text & media area in my Moodle instance. Here is a screen shot of a sample course:

Moodle is Version 4.1.10+ (Build: 20240503). I don’t know how to find out our Boost Union version, but it was recently installed. Do you know why we can’t locate a ‘Name’ field for the activity?

@.***

Kind regards,

Jane Sullivan Business Analyst University of Canterbury T: +64 27 309 5381 | E: @.***

From: HsH-Wolf @.> Sent: Monday, May 6, 2024 8:53 PM To: moodle-an-hochschulen/moodle-theme_boost_union @.> Cc: Jane Sullivan @.>; Mention @.> Subject: Re: [moodle-an-hochschulen/moodle-theme_boost_union] Issue: All sections display in course index and nothing happens when I select an item (Issue #637)

You don't often get email from @.**@.>. Learn why this is importanthttps://aka.ms/LearnAboutSenderIdentification

Dear @janeesullivanhttps://github.com/janeesullivan

could you please provide the Moodle and Boost union versions, you are using, since I am not able to reproduce the bug.

Furthermore, displaying the title of the text and media area (former label) or the beginning of its content, if there is no title, is Moodle core behaviour. (You can find the description here: https://docs.moodle.org/404/en/Text_and_media_area)

Best regards in bahalf of the Boost union team Yvonne

— Reply to this email directly, view it on GitHubhttps://github.com/moodle-an-hochschulen/moodle-theme_boost_union/issues/637#issuecomment-2095488525, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BH5BX42UHCYF4DG3UQ7XB6DZA5AHLAVCNFSM6AAAAABGR3GR5OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOJVGQ4DQNJSGU. You are receiving this because you were mentioned.Message ID: @.**@.>>

This email may be confidential and subject to legal privilege, it may not reflect the views of the University of Canterbury, and it is not guaranteed to be virus free. If you are not an intended recipient, please notify the sender immediately and erase all copies of the message and any attachments.

danmarsden commented 1 month ago

I think Yvonne has possibly identified the issue there - Moodle 4.1 doesn't have a "title" field in the label/ text and media area when creating/editing the label (that only exists in newer Moodle versions) - so it will always be empty - I suspect something from newer boost / boost _union code has been backported to the 4.1 branch incorrectly - in Moodle 4.1, labels aren't shown on the course index at all afaik.

Theme version installed is their site is: v4.1-r26 2023010561

danmarsden commented 1 month ago

hmm - that last comment was incorrect - standard boost theme "does" show the labels in the course index and as I look at this closer, it appears to be operating the same as core boost. including the incorrect links for mod_label when using one section per page.

I'm now leaning towards this not being a bug with boost_union, but there might be a possible feature request in there to disable showing "labels" in the course index? - although not sure if others might find this useful or not.

danmarsden commented 1 month ago

ah - nope... caching issue - boost_union in 4.1 course index shows resources/labels, standard Boost doesn't. (as long as cache is cleared properly...)

danmarsden commented 1 month ago

converting templates/core_courseformat/local/courseindex/cm.mustache back to the core version seems to fix this. (I didn't look further to see what part of the mustache template was causing this though.

whuml commented 1 month ago

Hallo @janeesullivan

I'd like to confirm @HsH-Wolf post: This is the (new) Moodle Boost core behaviour. Let me post my theme "BOOST" screenshots:

as explained under the questionmark:

Text_and_Media_area_no_title

shown in index even in "edit mode" off:

Text_and_Media_area_no_title2

As you click on the "text and media area" in the index it just jumps to the top of the page.

Within the Boost Union Team we are discussing, if there is a need/way to implement an "opt in" choice within course settings to hide "text and media area" in course index (see issue #583 ).

Hope that's what you pointed out

Best regards Wolfgang

whuml commented 1 month ago

see issue #583

danmarsden commented 1 month ago

@whuml keep in mind that the "name" field doesn't exist in 4.1 - the issue here that Jane is having is only on the 4.1 branch (not newer versions.) - the template used on the 4.1 branch should be different (and more like the 4.1 core boost templates/core_courseformat/local/courseindex/cm.mustache template.)

but - your other issue linked might provide a way around it (I haven't looked at it though.)