Improvement: Add navigation to policy overview page, resolves #633

christianwolters commented 1 month ago

Testing instructions:

configure moodle to use tool_policy as policy handler: admin/settings.php?section=policysettings
configure at least one policy to test overview: /admin/tool/policy/managedocs.php
open tool_policy overview page and check that there is no footer: admin/tool/policy/viewall.php
activate BU setting provided by this PR
open overview again, check that there is a menu and footer rendered: admin/tool/policy/viewall.php

abias commented 1 month ago

Thank you very much for this contribution, @christianwolters !

I have just reviewed your PR:

Review

Following https://github.com/moodle-an-hochschulen/moodle-plugin-maintaining/wiki/Check-list-for-peer-reviewing-patches-and-pull-requests

Documentation

[Y] Commit Message understandable and issue referenced (via resolves keyword)
[Y] Patch author correct
[Y] CHANGES.md appended
[Y] README.md appended
[-] Credits appended
[Y] Appropriate Comment quantity
[Y] Successful Moodle PHPDoc check

version.php

[Y] Checked if $plugin->version increment necessary (and increment done if necessary)
[Y] $plugin->release untouched

lib.php

[-] Only necessary functions

Languages

[Y] Only english strings
[-] Necessary magic strings added (e.g. capabilities)

Automated tests

[Y] New functionality covered
[Y] No failing steps or scenarios

Mustache templates

[-] Examle context exists

CSS and styles.css

[-] Bootstrap styles used if possible

Duplicated code

[-] Duplicated code is marked properly

Github action

[Y] All green

Commit history and scope

[Y] Already single commit
[Y] Focus on single purpose
[Y] No surplus files

Additional aspects for Boost Union

[Y] No usage of $theme->settings
[N] Usage of isset() checks when processing plugin settings in renderer / output code
[Y] Usage of admin_setting_configselect instead of admin_setting_configcheckbox
[-] Modified mustache templates properly marked and .upstream template in place

Review result

I have just added some minor changes in a "Review changes" commit, but apart from that the PR is ready to be merged. I will merge it as soon as the tests are green again.

kaaermes commented 1 month ago

Release Test: MOODLE 401 STABLE – tested using test instructions > OK MOODLE 402 STABLE – tested using test instructions > OK

moodle-an-hochschulen / moodle-theme_boost_union