search

moodle-an-hochschulen / moodle-theme_boost_union

Theme Boost Union is an enhanced child theme of Boost which is intended, on the one hand, to make Boost simply more configurable and, on the other hand, to provide helpful additional features for the daily Moodle operation of admins, teachers and students.
GNU General Public License v3.0
55 stars 49 forks source link

Improvement: Configurable "Documentation for this page" link in footer, resolves #649. #650

Closed lucaboesch closed 1 month ago

lucaboesch commented 1 month ago

On behalf of the Boost Union Team: 🎉 Thank you for contributing! 🎉

Please note: There must be a GitHub issue for every pull request (PR)

We kindly ask you to create a github issue now if you haven't already done so.

Please make sure to follow these steps to ease the review process for the peer review team:

[ ] link your issue in the PR title, using the keyword 'resolves #ISSUE-NUMBER', e.g. 'Feature: Provide the ultimate user experience, resolves #42' [ ] provide any further information that is relevant for peer review and not yet mentioned in the linked issue as a comment in the PR [ ] make sure that the 'Allow edits by maintainers' checkbox is checked when creating the PR. Otherwise, the peer reviewer would not be able to push any review changes to the PR and the communication overhead increases [ ] submit your PR in draft status to run the automated checks and review the results [ ] in case any checks fail solve the mentioned errors by pushing the corrected code to your PR-branch [ ] if all checks pass (or if you are unable to resolve the failing steps without any help of the review team), mark the PR as 'ready for review'

Thank you again for your contribution, we will start reviewing your PR as soon as we are able to.

In the meantime, please check our wiki page for creating pull requests and our wiki page for reviewing pull requests for further infomation about our contribution and review process.

lucaboesch commented 1 month ago

Thanks for your review, @abias. I'm puzzeled. Now, I can't reproduce the "New window" thing. In fact, until last week (I was able to prove this), with doctonewwindow set, the documentation page opened like this and not in a tab.

doctonewwindow
lucaboesch commented 1 month ago

With this commit, @abias, I address the points you raised.

Note that I did not opt for the wording "Show / hide icons before links in the footer" but sticked to "Suppress icons in front of the footer links" with the following reasoning. "Show / hide" isn't featured anywhere else yet. It is always "Suppress". "Suppress" is more user friendly. An admin, when she or he goes through the settings and sees "Show / hide" it seems like a call for action to decide ("Hhmh, what am I supposed to choose here? What is better, show or hide?") and might be not so intuitive. With "suppress" the logic is clear: when leaving on default, everything is unchanged from core Boost. (BTW, for consistency, 'Hide nodes in primary navigation' could also be renamed to 'Suppress nodes in primary navigation'. Do you want me to open an issue?)

Thanks for your great proposal!