Theme Boost Union is an enhanced child theme of Boost which is intended, on the one hand, to make Boost simply more configurable and, on the other hand, to provide helpful additional features for the daily Moodle operation of admins, teachers and students.
GNU General Public License v3.0
55
stars
49
forks
source link
Bug: External SCSS is dropped as soon as it uses SCSS variables (which are part of Moodle core or Bootstrap) #683
Unfortunately, this validation is only done for the external SCSS and not for the resulting SCSS stack. This means that if you use any SCSS variables from Bootstrap oder Moodle core in your external SCSS, the validation fails as these variables are not set yet.
This is a follow-up to #41 #652:
As it stands, the external SCSS feature has a design flaw: In https://github.com/moodle-an-hochschulen/moodle-theme_boost_union/blob/master/locallib.php#L2177-L2181, after the external SCSS is fetched and before it is added to the SCSS stack, it is check if it can be compiled correctly.
Unfortunately, this validation is only done for the external SCSS and not for the resulting SCSS stack. This means that if you use any SCSS variables from Bootstrap oder Moodle core in your external SCSS, the validation fails as these variables are not set yet.