Accessibility issue smartmenus

moodle-an-hochschulen / moodle-theme_boost_union

Theme Boost Union is an enhanced child theme of Boost which is intended, on the one hand, to make Boost simply more configurable and, on the other hand, to provide helpful additional features for the daily Moodle operation of admins, teachers and students.

GNU General Public License v3.0

67 stars 58 forks source link

Accessibility issue smartmenus #694

Open create-martin opened 4 months ago

create-martin commented 4 months ago

Describe the bug Using smart menus, the aria info aria-current="true" is not set correctly. So they fail in standard accessibility tests.

Since we have a lot of clients, that need to be as accessible as possible (there's actually some laws coming into effect in 2025 in Europe) this is quite troublesome.

To Reproduce Just create smartmenu --> e.g. just put a static page/dashbaord behind the link. aria-current is always on "dashboard"

Expected behavior having aria-current "moved" to correct place

Screenshots If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

OS: [e.g. iOS]
Browser [e.g. chrome, safari]
Version [e.g. 22]

Smartphone (please complete the following information):

Device: [e.g. iPhone6]
OS: [e.g. iOS8.1]
Browser [e.g. stock browser, safari]
Version [e.g. 22]

Additional context Add any other context about the problem here.

wiebkemueller-hsh commented 3 months ago

Hello @create-martin

thank you for highlighting this and also the legal implications there are in EU law. We have two questions:

Is the behaviour you are expecting only "behind the scenes" (the aria info aria-current="true") or is this also tied to a visual recognition to be made by the user? We've been talking about that in a ticket that should (if yes) then be linked to this issue.
You seem to already have had a very good insight in the details of the problem. Are you in any way able to provide a PR that could be integrated? We're still running short on DEV resources and help would be very much appreciated!

Regards on behalf of the DEV team! Wiebke

create-martin commented 2 months ago

Hi Wiebke,

I was on vacation, hence the delay in answering. As for the first question: to pass a11y tests, the "behind-the-scences" is probably enough. From a user experience point of view, I would very much like it, if the current menu option can also be visibly different from the other ones (using core, that would just be the underline hightlight; everything else can be done via theming anyway I suspect? is there a CSS class for it? or one could probably use the correctly-set-aria-label for it???).

As for developing ressources. I will check, please give me a couple of days to find out