search

moodle-an-hochschulen / moodle-theme_boost_union

Theme Boost Union is an enhanced child theme of Boost which is intended, on the one hand, to make Boost simply more configurable and, on the other hand, to provide helpful additional features for the daily Moodle operation of admins, teachers and students.
GNU General Public License v3.0
68 stars 60 forks source link

Fix cohort/rule deletion, resolves #737 #739

Closed marxjohnson closed 3 weeks ago

marxjohnson commented 1 month ago

On behalf of the Boost Union Team: 🎉 Thank you for contributing! 🎉

Please note: There must be a GitHub issue for every pull request (PR)

We kindly ask you to create a github issue now if you haven't already done so.

Please make sure to follow these steps to ease the review process for the peer review team:

[ ] link your issue in the PR title, using the keyword 'resolves #ISSUE-NUMBER', e.g. 'Feature: Provide the ultimate user experience, resolves #42' [ ] provide any further information that is relevant for peer review and not yet mentioned in the linked issue as a comment in the PR [ ] make sure that the 'Allow edits by maintainers' checkbox is checked when creating the PR. Otherwise, the peer reviewer would not be able to push any review changes to the PR and the communication overhead increases [ ] submit your PR in draft status to run the automated checks and review the results [ ] in case any checks fail solve the mentioned errors by pushing the corrected code to your PR-branch [ ] if all checks pass (or if you are unable to resolve the failing steps without any help of the review team), mark the PR as 'ready for review'

Thank you again for your contribution, we will start reviewing your PR as soon as we are able to.

In the meantime, please check our wiki page for creating pull requests and our wiki page for reviewing pull requests for further infomation about our contribution and review process.

marxjohnson commented 1 month ago

The first commit adds additional behat tests which reproduce the issue(s), the second commit fixes them.

marxjohnson commented 1 month ago

I think the tests were failing due to #734. I have rebased the branch with the fix, so hopefully everything passes now.

marxjohnson commented 4 weeks ago

I've updated the behat tests to work with the cohort deletion dialogue in 4.5+

marxjohnson commented 3 weeks ago

Tests are now passing for all stable branches.

abias commented 3 weeks ago

Hi @marxjohnson ,

thank you very much for this wonderfully crafted patch. I will integrate it now and will amend CHANGES.md and the Credits in README.md myself afterwards in a separate commit.

Cheers, Alex