search

moodle-an-hochschulen / moodle-theme_boost_union

Theme Boost Union is an enhanced child theme of Boost which is intended, on the one hand, to make Boost simply more configurable and, on the other hand, to provide helpful additional features for the daily Moodle operation of admins, teachers and students.
GNU General Public License v3.0
61 stars 56 forks source link

Improvement: Allow Boost Union to use its own fallback CSS file #89

Open abias opened 2 years ago

abias commented 2 years ago

Currently, Boost Union copies the fallback CSS file (which might be shipped by Moodle on the first page shippings after clearing the theme cache) from Boost Core (see https://github.com/moodle-an-hochschulen/moodle-theme_boost_union/blob/master/style/moodle.css) and it's the maintainer's job to update it every now and then to the state of the version in Boost Core.

However, as we start adding more and more CSS rules to Boost Union's SCSS codebase, it should be evaluated if Boost Union should use its own fallback CSS file as well. This way, Boost Union would not risk to appear weird even in the rare cases when to fallback CSS is shipped to particular users.

The plan to realize this would be probably:

abias commented 1 year ago

In https://github.com/moodle-an-hochschulen/moodle-theme_boost_union/commit/18a90de4c7b5b3187678bef17c4541275eba5c52, I have removed the fallback CSS file from Boost Union for now as it was just a copy from Boost Core and most of the time outdated as comparably many CSS changes are happening in Boost Core. This intermediate steps just eases our release management for now.

Anyway, this issue is still relevant and we should decide if we want a fallback CSS file of our own which includes Boost Union's feature styles.

danowar2k commented 1 year ago

If you removed the fallback CSS file, you should probably set https://github.com/moodle-an-hochschulen/moodle-theme_boost_union/blob/master/config.php#L31 to false (I think)