search

moodle-an-hochschulen / moodle-theme_boost_union_child

Boost Union Child is a boilerplate for enhancing Boost Union with custom or local functionality
GNU General Public License v3.0
4 stars 2 forks source link

Include Boost Union config using require instead of require_once #3

Closed larsbonczek closed 8 months ago

larsbonczek commented 8 months ago

In config.php, the Boost Union config should be included using require, not require_once, to make sure that all Boost Union settings are added to the $THEME object even if the Boost Union config was already included in some other place. https://github.com/moodle-an-hochschulen/moodle-theme_boost_union_child/blob/29d715cfe6815e1d4e65d1cbf4eac56d1c888fa7/config.php#L31-L33

abias commented 8 months ago

Thank you for this important note, @larsbonczek. I changed this behaviour in https://github.com/moodle-an-hochschulen/moodle-theme_boost_union_child/commit/beb3271353c75e0b3c70873fdd20e807559d8799.