search

moodle-fumihax / mod_lticontainer

Moodle Module for Integration System of Moodle and JupyterHub (with LTIContaionerSpawner).
https://github.com/moodle-fumihax/mod_lticontainer/wiki
Other
0 stars 0 forks source link

Frankenstyle naming violations #12

Open danmarsden opened 3 months ago

danmarsden commented 3 months ago

A large number of functions/classes in your plugin violate our frankenstyle naming rules

please see: https://moodledev.io/general/development/policies/codingstyle/frankenstyle

in particular files like your locallib files all violate these conventions.

note this is a blocker for plugins db approval.

danmarsden commented 3 months ago

also functions like the ones in this file are incorrect. https://github.com/moodle-fumihax/mod_lticontainer/blob/main/include/tabs.php#L42

danmarsden commented 3 months ago

also constants like the ones defined here are named incorrectly: https://github.com/moodle-fumihax/mod_lticontainer/blob/main/local_define.php