search

moodle-fumihax / mod_lticontainer

Moodle Module for Integration System of Moodle and JupyterHub (with LTIContaionerSpawner).
https://github.com/moodle-fumihax/mod_lticontainer/wiki
Other
0 stars 0 forks source link

consider adding github actions support - it's free and very useful. #14

Open danmarsden opened 5 months ago

danmarsden commented 5 months ago

Some of the tests run by the Moodle.org plugins db can be run via github actions on each commit in your github repo. Enabling this helps you to make sure future changes to your plugin will continue to follow the guidelines.

the short version - grab this file: https://github.com/moodlehq/moodle-plugin-ci/blob/master/gha.dist.yml rename it as ci.yml and put into the directory .github/workflows within tyour project eg: https://github.com/danmarsden/moodle-mod_attendance/blob/MOODLE_311_STABLE/.github/workflows/ci.yml

then on every commit you make to github it will fire off a request to run the tests and will give you traffic lights beside each commit and generate a report.

danmarsden commented 5 months ago

you should also review the codecheck errors reported in the plugins db here: https://moodle.org/plugins/mod_lticontainer/1.4.0/30757

note - full passing checks is not a requirement for plugins db approval but it does make the job of the review team a lot easier if your code complies better with the coding guidelines.