search

moodle-fumihax / mod_lticontainer

Moodle Module for Integration System of Moodle and JupyterHub (with LTIContaionerSpawner).
https://github.com/moodle-fumihax/mod_lticontainer/wiki
Other
0 stars 0 forks source link

SQL coding style - Indentation does have issues. #9

Open purnendudash opened 7 months ago

purnendudash commented 7 months ago

Sql statement should follow this indentation style - https://moodledev.io/general/development/policies/codingstyle/sql#indentation

https://github.com/moodle-fumihax/mod_lticontainer/blob/3bade7a5b11d272ac3a243996405c61790efb1da/locallib_db.php#L141

danmarsden commented 7 months ago

also - please review all SQL queries and ensure you are using placeholders correctly: https://moodledev.io/docs/4.4/apis/core/dml#placeholders

correct usage of Moodle's DML api is a requirement for plugins db approval.