moodle-saml / auth

Moodle SAML Auth plugin
https://moodle.org/plugins/auth_saml
3 stars 21 forks source link

No settings in Moodle 3.3 #12

Open imatotek opened 7 years ago

imatotek commented 7 years ago

Hi!

I have installed Moodle 3.3.1 (Build: 20170710), and there are no settings for saml authentication plugin. saml_auth

Are also there is no settings in dropdown menu: saml_auth_2

Can you please provide me with possibility for fixing this problem, we are using saml as our main source of authentication.

Thank you.

Ivica Matotek

Jarvil commented 6 years ago

Hello,

Is this coming for Moodle 3.3 @pitbulk ?

pitbulk commented 6 years ago

Sorry, there is no 3.3 version yet. I will try to get one in the next 2 weeks.

nadavkav commented 6 years ago

:+1: for fixing this

nadavkav commented 6 years ago

An initial working (wip) fix: https://github.com/moodle-saml/auth/compare/master...nadavkav:wip_m33_settings_support

pitbulk commented 6 years ago

I will review, but disable "course sync" is something not possible, a lot of integrations depend on that. We may assure back-compatibility.

nadavkav commented 6 years ago

It's is not a proper PR, just some initial wip (which works) settings.php page, for major setting, as we needed to be able to change some of those settings. I did not disable "course sync", just did not implemented an option to modify it, as we are not using it. it seemed lower priority for now.

logan-reynolds commented 5 years ago

Just noting I'm seeing this same problem on Totara 12.6, which is based on Moodle 3.3 - is there any newer stable version of auth_saml that will be posted to Moodle.org (or is available elsewhere) which resolves this issue so that the settings link is accessible?

pitbulk commented 5 years ago

Version auth/saml 15-01-2019 works with Moodle 3.4, If you using 3.3 you should use previous version.

logan-reynolds commented 5 years ago

Noting that we are testing previous version 2017011901 on Totara 12 (which is based on Moodle 3.3), and I'm still not seeing the settings link appear in the auth plugin management page. I would note that this could potentially be Totara-specific since our support tech noticed Totara removed the /admin/auth_config.php file for some reason in Totara 12, however I'm still thinking this could be a problem with the plugin code since copying that file into place doesn't fix things (i.e. still no settings link on T12 even when the /admin/auth_config.php file is present.)

I will do some more digging to see if I can find any further info or steps that make the settings page available, but please let me know if there is an intermediate version I should be testing of auth_saml somewhere between this 2017011901 and the maximum 20190115 version, or if a new stable 3.3 version is published; thank you.

logan-reynolds commented 5 years ago

I've confirmed that the previous version 2017011901 release 'auth/saml version of 19-01-2017' displays this problem with the Settings link missing from the auth_saml entry on the Manage Authentication page the same way on both Moodle 3.3 and Totara 12, so this problem is not specific to Totara 12. Please notify if a version supporting Moodle 3.3 is published, as we have a number of clients that would like to continue utilizing auth_saml if possible as they upgrade from Totara 11 to 12; Thank you.