search

moodle / devdocs

Source of the Moodle Developer Resources and Documentation
https://moodledev.io/
Other
36 stars 257 forks source link

[docs] Add documentation for new SMS API #1029

Closed andrewnicols closed 4 days ago

netlify[bot] commented 1 month ago

Deploy Preview for moodledevdocs ready!

Built without sensitive environment variables

Name Link
Latest commit 0dd6a694a00be262bc794b08ececf57d344aa0e9
Latest deploy log https://app.netlify.com/sites/moodledevdocs/deploys/668f46bfedd0d00008427790
Deploy Preview https://deploy-preview-1029--moodledevdocs.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

github-actions[bot] commented 1 month ago

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 55 🟢 95 🟢 100 🟢 90 🟢 100 Report
/docs/4.4/apis/commonfiles 🟠 69 🟢 93 🟢 100 🟢 100 🟢 100 Report
/general/development/gettingstarted 🟠 77 🟢 95 🟢 100 🟢 90 🟢 100 Report
/general/releases 🟠 67 🟢 95 🟢 100 🟢 100 🟢 100 Report
mickhawkins commented 1 month ago

Hi @andrewnicols,

This is great! Just a couple of minor suggestions:

  1. Under fetching messages, it would be useful to mention the message body will not be stored if the issensitive flag is true, and that those messages can only be sent synchronously for that reason.
  2. Should the example for get_messages (plural) use a named argument?