search

moodle / devdocs

Source of the Moodle Developer Resources and Documentation
https://moodledev.io/
Other
40 stars 291 forks source link

Refactored Index.js of theme/navbar #1067

Closed hamidayubdev closed 3 months ago

hamidayubdev commented 3 months ago

Simplified logic of returning Logo component in theme/navbar/logo/index.js by removing empty early return.

Refactored openMenu function in theme/navbar/index.js.

netlify[bot] commented 3 months ago

Deploy Preview for moodledevdocs ready!

Built without sensitive environment variables

Name Link
Latest commit d9567af23c9049e8e80df4125985a97cd38cc7cb
Latest deploy log https://app.netlify.com/sites/moodledevdocs/deploys/667f9f8397b4140008e1c67d
Deploy Preview https://deploy-preview-1067--moodledevdocs.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

github-actions[bot] commented 3 months ago

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 86 🟢 95 🟢 100 🟢 90 🟢 100 Report
/docs/4.4/apis/commonfiles 🟠 77 🟢 93 🟢 100 🟢 100 🟢 100 Report
/general/development/gettingstarted 🟠 66 🟢 95 🟢 100 🟢 90 🟢 100 Report
/general/releases 🟠 68 🟢 95 🟢 100 🟢 100 🟢 100 Report
hamidayubdev commented 3 months ago

@andrewnicols Which one doesn't work in all situations? This (refactored getVersion function to directly use versionName ...) commit?