search

moodle / devdocs

Source of the Moodle Developer Resources and Documentation
https://moodledev.io/
Other
40 stars 285 forks source link

Update 202403.md #927

Closed OlgaKoenig1 closed 6 months ago

OlgaKoenig1 commented 6 months ago

meeting link added

netlify[bot] commented 6 months ago

Deploy Preview for moodledevdocs ready!

Built without sensitive environment variables

Name Link
Latest commit 0ae23715c504bfbc852765c47ae81cefd477360c
Latest deploy log https://app.netlify.com/sites/moodledevdocs/deploys/65fada7a2d97550008e74f32
Deploy Preview https://deploy-preview-927--moodledevdocs.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

timhunt commented 6 months ago

Thanks :-)

github-actions[bot] commented 6 months ago

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🔴 42 🟠 87 🟢 92 🟢 90 🟢 100 Report
/docs/apis/commonfiles 🟠 57 🟠 85 🟢 92 🟢 100 🟢 100 Report
/general/development/gettingstarted 🟠 72 🟠 87 🟢 92 🟢 90 🟢 100 Report
/general/releases 🟠 68 🟠 87 🟢 92 🟢 100 🟢 100 Report
sarjona commented 6 months ago

@timhunt thanks for merging this. However, before merging it, it's recommended to wait for all the jobs to confirm there are no failures. If you look at the CI - Lint for Pull Requests / docs (pull_request) job, you'll see general/community/meetings/202403.md has a trailing space.

As this file will need to be edited once the meeting finishes, to post the recording, it's OK to leave it there for now (and fix it when it is updated). :-)

timhunt commented 6 months ago

Sorry, Sara. The button I clicked said "Merge when ready". I assumed that meant the merge would not proceed if any of the automated checking failed.

Clearly I was wrong about that. I won't do it again. (But also, can we configure it so it works the way I was expecting it to?)