moodlehq / moodle-cs

Moodle Coding Style
https://github.com/moodlehq/moodle-cs
GNU General Public License v3.0
18 stars 15 forks source link

Revert "Downgrade code to be PHP 7.0 compliant." #108

Closed stronk7 closed 7 months ago

stronk7 commented 7 months ago

This reverts commit edb2b8520ef8dd934700c092e4f0e6eccc3ea2ca.

This partially reverts some code that was done long ago to keep compatibility with PHP 7.0.

As far as moodle-cs now only supports PHP 7.4 and up, we can move back to use return types.

Fixes #107

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (73f0a60) 96.73% compared to head (68ca06c) 96.73%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #108 +/- ## ========================================= Coverage 96.73% 96.73% Complexity 586 586 ========================================= Files 26 26 Lines 1625 1625 ========================================= Hits 1572 1572 Misses 53 53 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.