search

moodlehq / moodle-cs

Moodle Coding Style
https://github.com/moodlehq/moodle-cs
GNU General Public License v3.0
18 stars 16 forks source link

Attributes should not be considered a side-effect #113

Closed andrewnicols closed 9 months ago

andrewnicols commented 9 months ago

The use of Attributes should not impact the MOODLE_INTERNAL check.

codecov[bot] commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 97.07%. Comparing base (a2f4209) to head (f6b5d75).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #113 +/- ## ========================================= Coverage 97.06% 97.07% - Complexity 632 633 +1 ========================================= Files 28 28 Lines 1807 1809 +2 ========================================= + Hits 1754 1756 +2 Misses 53 53 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

stronk7 commented 9 months ago

Uh, oh. Maybe we have to instruct phplint to stop looking within any fixtures dir?

stronk7 commented 9 months ago

As far as it's using Symfony Finder component (that accepts regexs), this seems to be working ok, and will make things easier for our new "distributed fixtures" agreement:

path: ./
exclude:
  - ~^vendor/~
  - ~/Tests(/.+)*/fixtures/~
andrewnicols commented 9 months ago

Huzzah - that did the trick. I hadn't realised we had the old fixtures excluded and I couldn't for the life of me work out why they were not failing.