Closed andrewnicols closed 8 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 97.82%. Comparing base (
6974134
) to head (613266f
).:exclamation: Current head 613266f differs from pull request most recent head 801e32a. Consider uploading reports for the commit 801e32a to get more accurate results
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Ho,
I'm not sure about this one... I don't think that we have required/suggested to document all the unit tests (functions) in the past (although I've not been able to find any reference in one - or the opposite - direction).
Uhm... impact out there can be certainly huge, if they were being skipped previously...
Not sure, not sure...
Bah - I think I missed a line in the old version. The old coding style made my brain completely miss that line, and there really weren't any good tests for the old one.
So we didn't previously add the error for test_ methods.
Added a commit to this patchset to do match that behaviour.
Either:
All are very easy to implement.
I've gone for the middle ground for now.