search

moodlehq / moodle-cs

Moodle Coding Style
https://github.com/moodlehq/moodle-cs
GNU General Public License v3.0
18 stars 15 forks source link

Line length ignore for docs #128

Open andrewnicols opened 6 months ago

andrewnicols commented 6 months ago

Scratching an itch.

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 97.86%. Comparing base (24bc48a) to head (7aef373).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #128 +/- ## ============================================ + Coverage 97.81% 97.86% +0.04% - Complexity 827 832 +5 ============================================ Files 35 35 Lines 2426 2430 +4 ============================================ + Hits 2373 2378 +5 + Misses 53 52 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

stronk7 commented 6 months ago

Heh,

from the examples in the PR, I feel that only the @Given has a pass. The other 2 long cases (leaving apart the lang test that is unrelated) in phpdoc block and inline comment... I'd say that they should continue throwing warning/error. We don't want those long comments for any reason. Do we?

Maybe we can restrict the skipping to be a little more selecive (by tag, or by regex, ...).

Ciao :-)

andrewnicols commented 6 months ago

We can... I'll update the patch some time later. Let's not block on this one. It's just one that does my head in!