Closed andrewnicols closed 7 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 97.82%. Comparing base (
3bfeb70
) to head (38a3204
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I wholly agree but let’s do it as a separate PR. I saw this one and did go and check and there’s a mix of both
It isn’t valid but I don’t think we have an example. Can put one together. Won’t be home for a few hours so don’t know if you want to add one and test in my absence?
Done:
MOODLE_INTERNAL
removals.My side, this is ready now. I'll leave you, @andrewnicols , to make the merging honours if everything looks ok for you.
Ciao :-)
The line no was not updated to the line of the opening attribute.
Thanks to @ziegenberg for the test here. Note: I had to amend it because PHP 7.4 cannot support multiline attributes, only single line (which are treated as comments)
Also please note that it is not necessary to sign-off your own commits. Typically the
Signed-off by
is used for peer code review.