moodlehq / moodle-cs

Moodle Coding Style
https://github.com/moodlehq/moodle-cs
GNU General Public License v3.0
18 stars 16 forks source link

Fix docblocks before Multiline attributes #132

Closed andrewnicols closed 7 months ago

andrewnicols commented 7 months ago

The line no was not updated to the line of the opening attribute.

Thanks to @ziegenberg for the test here. Note: I had to amend it because PHP 7.4 cannot support multiline attributes, only single line (which are treated as comments)

Also please note that it is not necessary to sign-off your own commits. Typically the Signed-off by is used for peer code review.

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 97.82%. Comparing base (3bfeb70) to head (38a3204).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #132 +/- ## ========================================= Coverage 97.82% 97.82% Complexity 826 826 ========================================= Files 36 36 Lines 2432 2432 ========================================= Hits 2379 2379 Misses 53 53 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

andrewnicols commented 7 months ago

I wholly agree but let’s do it as a separate PR. I saw this one and did go and check and there’s a mix of both

andrewnicols commented 7 months ago

It isn’t valid but I don’t think we have an example. Can put one together. Won’t be home for a few hours so don’t know if you want to add one and test in my absence?

stronk7 commented 7 months ago

Done:

stronk7 commented 7 months ago

My side, this is ready now. I'll leave you, @andrewnicols , to make the merging honours if everything looks ok for you.

Ciao :-)