search

moodlehq / moodle-cs

Moodle Coding Style
https://github.com/moodlehq/moodle-cs
GNU General Public License v3.0
18 stars 15 forks source link

Add new sniff to detect and remove constructor @return docs #157

Closed andrewnicols closed 3 months ago

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 97.96%. Comparing base (bc14e30) to head (9573f90).

:exclamation: Current head 9573f90 differs from pull request most recent head 228d21b

Please upload reports for the commit 228d21b to get more accurate results.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #157 +/- ## ============================================ - Coverage 97.99% 97.96% -0.04% + Complexity 886 873 -13 ============================================ Files 39 39 Lines 2647 2603 -44 ============================================ - Hits 2594 2550 -44 Misses 53 53 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

andrewnicols commented 5 months ago

@marinaglancy

Inspired by your docblock fixes.

stronk7 commented 4 months ago

LGTM.

The removal looks a little bit complex, more yet, I must confess that I was sure that the fixer had some utility function to remove lines, but I was wrong and it only has functions to add new ones (addNewline() and addNewlineBefore()).

stronk7 commented 3 months ago

pong!

andrewnicols commented 3 months ago

I agree - there should really be a removeLine!! Drives me mad that there isn't.

@marinaglancy are you able to review this?

stronk7 commented 3 months ago

I've amended the commit to resolve the changelog conflicts.