search

moodlehq / moodle-cs

Moodle Coding Style
https://github.com/moodlehq/moodle-cs
GNU General Public License v3.0
18 stars 16 forks source link

Do not warn about missing docblocks when a method has the #[\Override] attribute #160

Closed andrewnicols closed 5 months ago

andrewnicols commented 7 months ago

Fixes #155

POC

andrewnicols commented 7 months ago

Need to add some unit tests for attributes helper.

I'm not going to make this handle fully-qualified checks right now. We'll see if phpcsextra or phpcs do so.

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 97.93%. Comparing base (c9b7667) to head (fa1c22b).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #160 +/- ## ============================================ + Coverage 97.90% 97.93% +0.03% - Complexity 850 860 +10 ============================================ Files 37 38 +1 Lines 2524 2564 +40 ============================================ + Hits 2471 2511 +40 Misses 53 53 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

andrewnicols commented 5 months ago

I've been running this locally for the past month and haven't encountered any weird bugs or issues. Pushing for review.

stronk7 commented 5 months ago

(whops, if you could rebase this on top of current main, that would be great, I'll do in a couple of hours if you cannot)