moodlehq / moodle-cs

Moodle Coding Style
https://github.com/moodlehq/moodle-cs
GNU General Public License v3.0
18 stars 16 forks source link

Better integration tests, with correct exit status checks #161

Closed stronk7 closed 5 months ago

stronk7 commented 5 months ago

There were a few problems with the integration checks, not properly detecting & asserting the expected exit statuses. Plus some problem using runner.os that uses different names (Linux, Windows, macOS), so switching to matrix.os

Now they are better checked, with some output added to explain the problem when the script runs.

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 97.90%. Comparing base (1ec84f4) to head (cb7f4ad).

:exclamation: Current head cb7f4ad differs from pull request most recent head ef0b764. Consider uploading reports for the commit ef0b764 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #161 +/- ## ========================================= Coverage 97.90% 97.90% Complexity 850 850 ========================================= Files 37 37 Lines 2524 2524 ========================================= Hits 2471 2471 Misses 53 53 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

stronk7 commented 5 months ago

Tata!